lingui / js-lingui

🌍 📖 A readable, automated, and optimized (3 kb) internationalization for JavaScript
https://lingui.dev
MIT License
4.63k stars 382 forks source link

docs: refactor installation instructions #2060

Closed andrii-bodnar closed 4 weeks ago

andrii-bodnar commented 1 month ago

Description

This pull request aims to reduce user confusion in the Getting Started section of the website and put all installation and basic setup instructions in one place. This also makes the Getting Started section more framework/toolkit-agnostic.

A quick overview of the changes:

From the reader's perspective, the React Project and Vite Project were confusing since it's not clear why it was differentiated into React and Vite and it could lead to wrong assumptions or questioning all of this even more.

In general, it should reduce code duplication and make reading easier for the developer.

🖼️ Deployment Preview

Types of changes

Checklist

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Oct 23, 2024 7:40am
github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 3.09 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.65 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)
timofei-iatsenko commented 1 month ago

I'm reviewing thru reading docs on the deployment preview, will write down here a notes:

I'm continuing reviewing

andrii-bodnar commented 1 month ago

@timofei-iatsenko thanks for the quick review. Just pushed the updated version.

andrii-bodnar commented 1 month ago

I also think it would be nice to add Rspack and Webpack to the Build Tools section in the new article.

andrii-bodnar commented 1 month ago

@vonovak thanks for the review! I have updated everything according to your suggestions.