search

lingxz / er

:snail: a hugo theme
https://themes.gohugo.io/theme/er/
MIT License
59 stars 25 forks source link

[Question] Support for Staticman comments #8

Open VincentTam opened 5 years ago

VincentTam commented 5 years ago

Hi, this is the author of Beautiful Hugo's Staticman nested comment support halogenica/beautifulhugo#222.

Anyone using this theme would be interested in having Staticman?

lingxz commented 5 years ago

Hey, just a heads up, personally I won't merge comments support into the main branch because as mentioned previously I wanted the theme to be quite minimal, but I'm completely open to having comments support in a separate branch/PR for people to switch to it if they wish to.

rootkea commented 5 years ago

I'm completely open to having comments support in a separate branch/PR for people to switch to it if they wish to.

Well, this will work too. Thanks for being open to suggestions. :)

VincentTam commented 5 years ago

Setting up a separate branch for a new feature will facilitate testing. (git pull origin feature vs git pull origin pull/222/head) Contributors can only propose PR to existing upstream branches. I suggested creating a dev branch as in eduardoboucas/staticman#231 for PR proposals.

lingxz commented 5 years ago

yes, I'm just saying I won't merge it, but we can leave it in a separate branch. There's no need for a dev branch for now, you can just raise PR against master.

VincentTam commented 5 years ago

I'll try two weeks later.