search

lingz / alphabetical_paginate

An Alphabetical Pagination gem for Ruby on Rails
MIT License
24 stars 25 forks source link

It shouldn't show any pagination bar when no data is available #34

Closed dej611 closed 9 years ago

dej611 commented 9 years ago

As in will_paginate, the pagination bar should be hidden when there's no data to paginate I think.

Seeing the following makes me assume that there's something else in a different letter: screen shot 2015-02-22 at 18 30 12

While I see that this may have an impact on performances, it may prevent the user to try to attempt random clicks while browsing.

In will_paginate it just doesn't render the pagination bar when no data it's available: screen shot 2015-02-22 at 18 30 25

dej611 commented 9 years ago

Made it work with the #35 pull request.

lingz commented 9 years ago

Already merged and released in 2.3.0