search

linien-org / linien

Spectroscopy lock application using RedPitaya
GNU General Public License v3.0
74 stars 19 forks source link

Don't use `fire`, and use good old argparse #418

Open doronbehar opened 3 months ago

doronbehar commented 3 months ago

Hello @bleykauf .

I just managed to install the server in an offline manner (more details about that experience in https://github.com/linien-org/linien/issues/378#issuecomment-2265126113 ). This dependency is problematic and it is not worth it IMO. Here's why:

First of all, there's this upstream issue which very annoyed me when I wanted to use the new CLI interface for the first time. It took me ~half an hour to explain exactly what was wrong and to find out that it was the library's fault.

Secondly, they don't distribute a .whl file to pypi which was a bit annoying in one of my attempts to iterate the dependencies of the server when trying to send them all via ssh (this is mentioned in this pip issue.

And lastly, for target hosts without a real internet connection, it is generally useful to reduce the number of dependencies.

I can help with the transition to argparse, but I seek your approval on the subject first.