linikujp / owltools

Automatically exported from code.google.com/p/owltools
0 stars 0 forks source link

Error in building of topology graph in solr loading #105

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Test case:

OWLTools-Solr/src/test/resources/topology-test.obo

See also:

http://jira.geneontology.org/browse/GO-626

The topology graph edge between 

GO:0030414 (peptidase inhibitor activity
and
GO:0008233 (peptidase activity)

Should *not* be part_of.

The paths are:

 * P, NR
 * I, R (which reduces to R)

This is calculated directly by the OGW. For the topology graph, all that needs 
to be done is a straightforward translation of the list returned by OGW, with 
reduced paths of length>1 discarded.

The problem here may reside in getEdgeLabel in OGWE, which makes a dangerous 
call to getSingleQuantifiedProperty.

Original issue reported on code.google.com by cmung...@gmail.com on 4 Nov 2014 at 12:36

GoogleCodeExporter commented 9 years ago
Correction: transitivity graph

Original comment by cmung...@gmail.com on 4 Nov 2014 at 8:51

GoogleCodeExporter commented 9 years ago
There is now some better documentation for purpose and structure of the GOlr 
graphs (via BBOP JS):

https://github.com/kltm/bbop-js/wiki/Graph
https://github.com/kltm/bbop-js/wiki/TopologyGraph
https://github.com/kltm/bbop-js/wiki/TransitivityGraph

Original comment by sjcar...@lbl.gov on 4 Nov 2014 at 11:05

GoogleCodeExporter commented 9 years ago
Pushed a fix for the issue in r2400. The correct results are now calculated 
using the ExpressionMaterializingReasoner for Amigo/Solr. 
See also the test case 
OWLTools-Solr/src/test/java/owltools/solrj/TransitivityGraphTest.java

Original comment by HDie...@lbl.gov on 6 Nov 2014 at 10:21

GoogleCodeExporter commented 9 years ago
A failing integration test related to GAF Solr loading revealed some issues on 
the memory requirements (and unnecessary computations) for the setup of the 
ExpressionMaterializingReasoner.
The strategy is now to only create expressions for a requested subset of 
properties.

Original comment by HDie...@lbl.gov on 21 Nov 2014 at 7:07