search

linjer / jekyll-katex

[DEPRECATED] Jekyll plugin for easy server-side math rendering via KaTeX
MIT License
97 stars 8 forks source link

Jekyll 4 support #27

Closed boramalper closed 5 years ago

boramalper commented 5 years ago

Jekyll 4 is released recently and jekyll-katex depends on Jekyll 3.0 thus won't work with the latest version.

MahdiBaghbani commented 5 years ago

I had actually tested jekyll-katex (a modified fork that has jekyll 4.0 as requirement) and everything went good. I think it's safe to update gem file to point at the new jekyll version.

linjer commented 5 years ago

@boramalper Thanks for raising this to my attention. Can you try and see if version 1.0.0 I just published now works?

boramalper commented 5 years ago

You're welcome! I am afraid I cannot help as I already opted for manually setting it up in my themes (and giving up on server-side rendering).

MahdiBaghbani commented 5 years ago

I've already played with it in my developing Jekyll theme, can confirm it worked for version 4 and rendered existing math expressions. but my math expressions are so simple and few (5 at all).

linjer commented 5 years ago

@boramalper Sorry I couldn't provide timely support. I have stopped maintaining a Jekyll site entirely so I am unfortunately no longer a user. I'll close out this issue for now as a result and if you or anyone else finds the problems persist, please let me know.

@MahdiBaghbani If I am understanding you correctly, you've tried playing around with the published 1.0.0 version and it seems to be working for the simple cases you have. Am I correct? Thank you so much for contributing.

MahdiBaghbani commented 5 years ago

yes, It worked for me.

boramalper commented 5 years ago

@linjer No worries at all! Thank you for your hard work. =)