search

linjunpop / riif

🏦 A DSL to generate QuickBooks IIF file.
MIT License
47 stars 30 forks source link

Changes to stop overwriting the official 'rake' executable when installing this gem. #40

Closed 0x1eef closed 5 years ago

0x1eef commented 5 years ago

This gem overwrites the official rake executable when it is installed through Bundler. The rake executable from this gem requires Bundler to work and breaks when outside a Bundler project. Besides, your gem should not be overwriting the executables of other gems.

Please consider this pull request or devise your own solution that doesn't install a broken rake when this gem is installed through Bundler.

I have also opened an issue on the Bundler tracker asking to do the same as rubygems by showing a confirmation prompt in case a gem like this one overwrites the executable from another gem.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 99.348% when pulling b8837ff539ea8ad16dfcf3faebf80f65d1843bf4 on rg-3:master into 8bf8f8cef5df334a894beceab23dd82767143fa0 on linjunpop:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.003%) to 99.351% when pulling b8837ff539ea8ad16dfcf3faebf80f65d1843bf4 on rg-3:master into 8bf8f8cef5df334a894beceab23dd82767143fa0 on linjunpop:master.

linjunpop commented 5 years ago

Many thanks.

0x1eef commented 5 years ago

Thanks Jun Lin. Do you know when we can expect a new release?

linjunpop commented 5 years ago

Hi @rg-3, https://rubygems.org/gems/riif/versions/0.9.0 released.

0x1eef commented 5 years ago

Thanks!