DSL inner blocks accept argument to yield

linjunpop / riif

🏦 A DSL to generate QuickBooks IIF file.

MIT License

46 stars 30 forks source link

DSL inner blocks accept argument to yield #45

Closed mcelicalderon closed 3 years ago

mcelicalderon commented 3 years ago

Hi! So I found myself using this gem to generate an IIF file without using Rails templating system. The only problem I found was that by using instance_eval in the inner blocks you loose access to the outer variables where this code might be executing. Just did the same that is already done for the main object IIF. Let me know what you think!

coveralls commented 3 years ago

Coverage increased (+0.3%) to 99.603% when pulling 61e447a2367e187c7914ffab04daff155290419a on mcelicalderon:inner-blocks-accept-argument into 97ce39698425a16a42fa73267ca6911d0ff52340 on linjunpop:master.

linjunpop commented 3 years ago

Looks good to me! Thank you very much.

mcelicalderon commented 3 years ago

Thank you for merging! If you could release a new version with the change I would really appreciate it so I can stop using a repo on my Gemfile.

linjunpop commented 3 years ago

Hi @mcelicalderon,

Sorry for the late response. 1.1.0 just released.