link-u / cavif

avif encoder, using libaom directly.
MIT License
111 stars 19 forks source link

won't build on macos #104

Open dbquarrel opened 3 years ago

dbquarrel commented 3 years ago

vmaf fails during build/install...

Overall it seems to be a bad idea to force the user to download and compile all of these libraries (libpng, libaom, libvmaf) when package managers do this well and the entire concept of libraries is that you don't need to download them into your project.

So please consider letting users manage the dependencies and install them as an option if they are not present.

G2G2G2G commented 3 years ago

vmaf fails on arch as well (probably every linux) seems to be due to the bundled dependency? because it doesn't touch the actual library which is installed on my system separately (as a normal library)

and is already posted about here https://github.com/link-u/cavif/issues/97

ledyba-z commented 2 years ago

I changed dependency management. Also, I found that currently libaom tends to make static execution binary, which is impossible in mac OS. However, I made a workaround.

Could you try a new build procedure?

ledyba-z commented 2 years ago

Overall it seems to be a bad idea to force the user to download and compile all of these libraries (libpng, libaom, libvmaf) when package managers do this well and the entire concept of libraries is that you don't need to download them into your project.

To tell you the truth, I am analyzing entire source code (including libraries) with CLion, to make development more easier.

It is why most of libraries are managed and by one cmake project.

So please consider letting users manage the dependencies and install them as an option if they are not present.

I agree. However, please let me make the priority lower...

ledyba-z commented 2 years ago

New patch is landed. We don't have to rewrite build.ninja using sed.

https://github.com/link-u/cavif/commit/351ec0f204def32d288cc01c4d2572bb6c79d388

ledyba-z commented 2 years ago

Currently, zlib/libpng/libvmaf are built separately from cavif.

https://github.com/link-u/cavif/commit/6e720e81738a817b5c16fa4e532ac503d4f23209