search

link0 / bunq

API client in PHP for bunq
MIT License
8 stars 13 forks source link

Updated readme and removed the a instance requirement #6

Closed dstollie closed 7 years ago

dstollie commented 7 years ago

What has been done

Updated the read me to more clear for new developers who are trying to adopt the package.

Be able to create a DeviceServer and SessionServer using only the string presentation of a token and not a specific instance. The reason why why I have changed this is because a token is not being stored as a Token instance. Its being stored as string. With this pr you can submit a string presentation of the token instead.

dennisdegreef commented 7 years ago

Thanks for your contribution! I've left some comments. This also shows me a few problems with the example script and the clarity. Thanks for that! I will also update the docs with the new Token.

dstollie commented 7 years ago

Hi @dennisdegreef ive updated my fork with your comments :).

dennisdegreef commented 7 years ago

Thanks! I'll also change the docs when I fully move to using the Token class.