search

link2aws / link2aws.github.io

Get AWS console link from ARN
https://link2aws.github.io/
36 stars 20 forks source link

Add support for VPC #34

Closed wenyichen closed 2 years ago

fxkr commented 2 years ago

Thank you very much for the contribution!

Unfortunately the unit test has failed. Could you please update the code to resolve this?

The problem is that the new code explicitly adds .aws.amazon.com, which is not correct as ${this.console} already includes it. To give some background on why this string cannot be hardcoded there: Amazon operates multiple completely separate instances of AWS other than the "main" one you are probably used to, for example the GovCloud console is at https://console.amazonaws-us-gov.com/console/home

wenyichen commented 2 years ago

Ah yeah sorry about that. Fixed this one and I'll have a couple more incoming for various services. Thanks for you work!

fxkr commented 2 years ago

Thank you very much!

Looking forward to more!

fxkr commented 2 years ago

Released as version 1.0.11