bugfix: use NetworkManager for ubuntu netplan

linka-cloud / d2vm

Build Virtual Machine Image from Dockerfile or Docker image

Apache License 2.0

208 stars 31 forks source link

bugfix: use NetworkManager for ubuntu netplan #45

Closed SubaruArai closed 7 months ago

SubaruArai commented 8 months ago

The template config was hardcoded to eth0 and google dns. This pr changes to NetworkManager instead, which is the default on Ubuntu 20.04 and 22.04.

NOTE: I'm not sure if we should change debian as well, I tried with debian12 and it seems like network-manager isn't installed by default, and NetworkManager.service was not loaded.

Adphi commented 7 months ago

Hello @SubaruArai, thanks for the Pull Request.

I cannot merge this, because we want to stick to the minimalist defaults and the ubuntu docs says:

By default network management on Ubuntu Core is handled by systemd’s networkd and netplan.

SubaruArai commented 7 months ago

@Adphi Checked, fair enough! It's weird though, maybe it's a desktop ver. only thing? (I checked NetworkManager on Ubuntu desktop)