Updating subprocess module syntax according to python3

linkagescape / linkage-mapper

ArcGIS tools to automate mapping and prioritization of wildlife habitat corridors

https://circuitscape.org/linkagemapper/

GNU General Public License v3.0

37 stars 12 forks source link

Updating subprocess module syntax according to python3 #148

Closed venkanna37 closed 2 years ago

venkanna37 commented 2 years ago

ArcGIS Pro 2.8.1 is raising error due to changes in the python (3) and subprocess module versions. The issue opened at #147. I have modified the code that works with both ArcGIS and ArcGIS Pro > 2.8. But the issue after merging this code will be the GRASS GIS window will open when initializing the works space (instead of hiding and run the process in the backend), this has to impove.

johngallo commented 2 years ago

Thanks Venkanna! I am traveling so will not be able to test this myself soon. I am considering approving the pull request (the code looks good), and finishing the Beta Release. Beta testers can double check. To confirm: Are you saying that you fixed the error, and that Climate Linkage Mapper now runs with ArcPro 2.8? But when running it the GRASS window opens on top, which is not pretty? When the run is complete the window can be closed correct?

venkanna37 commented 2 years ago

Yes John, Climate Linkage Mapper now runs with the ArcPro 2.8. Also when the run is complete, the window closes (within milliseconds).