search

linkagescape / linkage-mapper

ArcGIS tools to automate mapping and prioritization of wildlife habitat corridors
https://circuitscape.org/linkagemapper/
GNU General Public License v3.0
39 stars 12 forks source link

Iterate barriers #31

Closed dkav closed 6 years ago

dkav commented 6 years ago

@johngallo do you want to keep this script around? It was added by Brad back in 2013 but it was never implemented into a tool. Although I have tidied the code up in a separate branch, I can delete the file if it has no value going forward.

johngallo commented 6 years ago

@dkav I don't think it hurts to keep it, especially if you could elaborate a bit more about what it does, or your guess about what it does. Currently it only says this, correct? """Script to iteratively run linkage mapper and barrier mapper tools restoring for max ROI""" Does it mean that you run Linkage mapper, then barrier mapper, then assume that you conserve the highest priority barriers and make them more passable, and then run again? Or does it assume those areas become cores? Sounds intriguing either way. ( @aprisbrey looks like you can ignore my earlier e-ail, unless I am confused and this is not related to the earlier)

dkav commented 6 years ago

@johngallo I had no involvement in the code, so I haven't spent much time understanding what it does other than getting it to work for testing purposes. Bellow is output from a test run, which might answer your questions. 

Finding restoration circles with max barrier score / ROI
Creating mask for previously restored areas
Creating candidate restoration raster using barrier results, previous restorations, and selection criteria
Maximum barrier improvement score: 411159.25
Maximum purchase ROI score: 1.83802423998713E-03
Maximum total ROI score: 1.0322374291718E-03
Choosing circle with maximum BARRIER IMPROVEMENT SCORE to restore
Done evaluating candidate restorations

Creating restoration circles
Rasterizing restoration circles
Digitally restoring resistance raster
Finished iteration #2

I would suggest that the file be deleted from the develop branch (and eventually the master branch) if it is not being used and has no documentation. Keep in mind it will still exist in the repo if you need it back. To help further, a feature enhancement issue that references the file in the repo could be created to serve as a placeholder for future possible development. Alternatively, if you forsee implementing the feature in the near-term you could create a branch that includes the deleted file.

@aprisbrey this includes part of pull request #30. So both will need to be merged.

johngallo commented 6 years ago

@dkav and @aprisbrey So it looks like there are two things here:

1) to merge the two commits pull request 2) a decision about deleting that script

Annie, can you take a look at the commits and accept them if they look good to you? Regarding #2, I think I see where he was going with it and I'd like to tinker with it someday. If we leave it as is, it won't get forgotton. But if that is too messy in either of your opinions, we can discuss. Regardless, the above text can be pated into a new issue which is either to clean it up, or to further develop it. Annie can you do that to, chhosing for the further develop option unless we hear otherwise from Darren?

dkav commented 6 years ago

You could a create a separate repo in the linkagescape account to store this and similar endeavors. It is possible to move a single file and maintain its history too (see this answer from Stack Overflow).

aprisbrey commented 6 years ago

It's unclear to me what you're wanting here - am I merging this pull request or are we just deleting the iterate barriers script? Or both?

dkav commented 6 years ago

As far as I am concerned, you can merge the changes. The file can be deleted in a separate commit if John agrees.

johngallo commented 6 years ago

Just merging the pull request. What to do with the iterate barriers script is an open question. Thanks Annie.

On Thu, Apr 19, 2018 at 2:00 PM, Annie Prisbrey notifications@github.com wrote:

It's unclear to me what you're wanting here - am I merging this pull request or are we just deleting the iterate barriers script? Or both?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/linkagescape/linkage-mapper/pull/31#issuecomment-382879357, or mute the thread https://github.com/notifications/unsubscribe-auth/AP4k6-4tsMIxKoMVGYhYZ6FsEOPNPHv-ks5tqPsJgaJpZM4S_fcQ .

--

John Gallo, Ph.D. Senior Scientist Conservation Biology Institute https://consbio.org/people/staff/john-gallo 136 SW Washington Avenue, Suite 202 Corvallis, OR 97333 Remote Office: Inglenook, CA Phone: 707.962.9078 Twitter: @johnagallo https://twitter.com/johnagallo