search

linkeddata / dokieli

:bulb: dokieli is a clientside editor for decentralised article publishing, annotations and social interactions
https://dokie.li/
Other
803 stars 82 forks source link

Add check, if User LoggedIn/LoggedOut with OIDC or relogin with new OIDC WebID #265

Closed smalinin closed 5 years ago

smalinin commented 5 years ago

Fixed version of https://github.com/linkeddata/dokieli/pull/263 with using function solid.auth.currentSession

Hang on.. do we actually need it? The toggling works fine. As far as I can see, the session is not shared across tabs/windows.. am I overlooking something? It is shared between tabs, because OIDC session is stored on page localStorage, so it is shared between pages with same window.location.origin

csarven commented 5 years ago

Thanks! Can the PR be a single commits right after 8fdbbebd2c4ca1cdcb0ffe7cabe37f7737a4564e ?

smalinin commented 5 years ago

Thanks! Can the PR be a single commits right after 8fdbbeb ?

Not right after 8fdbbeb I could create only an another version (from an another more clear branch) https://github.com/linkeddata/dokieli/pull/267

csarven commented 5 years ago

If your work repository is syncronised with dokieli's, it shouldn't happen.

I've just updated the development documentation at https://github.com/linkeddata/dokieli#development . That's normally how I go at it and pretty standard as far as I can tell. Would you mind going through that process and see if it works for you? Most of that is copy/paste.. and when you get to step "Make your code updates", you just have to copy the updates that you've made here.