search

linkeddata / gold

Linked Data server for Go
151 stars 35 forks source link

update README & add vendoring #98

Closed err0r500 closed 6 years ago

err0r500 commented 6 years ago

I just cleaned up the README a little bit (mainly split the go installation and system the dependencies)

I also used dep to vendor the project

deiu commented 6 years ago

Hey! Thanks for the PR. Please let me know when you're done and you'd like a review.

err0r500 commented 6 years ago

Hi, Thanks to you for this great project ! I guess it should be fine now. I removed the magicmime dependency and replaced it with gabriel-vasile/mimetype in order to remove a C dependency. Tell me what you think about it

deiu commented 6 years ago

It looks like I no longer have admin access for this repo, so you'll have to wait for (or ping) someone in the Solid team to merge it.

err0r500 commented 6 years ago

Hahaha, ok, no problem. I think I'll close these PRs and continue on my fork. Thanks a lot !

melvincarvalho commented 6 years ago

@deiu happy to add you, thanks for looking in! :)

joe-mcnuggets commented 6 years ago

@err0r500 I think it would be good if this PR will be merged, because I'll rewrite Dockerfile at my fork and will need dep too (:

err0r500 commented 6 years ago

@joe-mcnuggets no problem, I won't touch this repo anymore ! :) I pushed gold in another repo of mine to attempt a big refactoring since :

  1. I'm not sure it will be a succesful attempt :)
  2. I can understand some may be unpleased by the changes I make
  3. I had to comment temporarily the server tests because they seemed to be based on mutations that were difficult to reproduce
  4. Anyway, moving all the stuff back to the original gold repository may not be too difficult if the original maintainers are interested in.
deiu commented 6 years ago

I looks like I got my access back, but I can't seem to find a way to manually trigger a build on Travis for this PR. @err0r500 can you please push a quick change to see if it auto-triggers a build?

err0r500 commented 6 years ago

hmmm, maybe a dep ensure would fix the problem

deiu commented 6 years ago

Any thoughts on why the tests fail?

err0r500 commented 6 years ago

Hi! TestFakeSMTPSecureDial() is failing in travis (works fine on my machine) so it may be env related