Produce the complete set of .d.ts files

linkeddata / rdflib.js

Linked Data API for JavaScript

http://linkeddata.github.io/rdflib.js/doc/

Other

564 stars 143 forks source link

Closed pduchesne closed 2 years ago

pduchesne commented 2 years ago

The current TS types are incomplete, as they do not contain types for the js files. This causes TS projects with "noImplicitAny=true" to fail.

This PR does 2 things :

have the build:types script include the js files
do the minimal set of fixes in those files to have the type checker succeed in producing type files

Ideally the whole set of js files should be migrated to ts; this PR does not go that way and is a minimal effort to have complete types.

bourgeoa commented 2 years ago

@Vinnl @ludwigschubi Are there any reason not to merge this PR to finally have rdflib with TS support.

Vinnl commented 2 years ago

I don't know, I'm not an rdflib maintainer so I wouldn't block it :)

bourgeoa commented 2 years ago

@angelo-v I suppose the npm-publish-build failed is not an issue here.

angelo-v commented 2 years ago

@bourgeoa it's an unrelated problem. Can you check the token @timbl ?

ludwigschub commented 2 years ago

Just tested it locally, works 👍