linkeddata / rdflib.js

Linked Data API for JavaScript
http://linkeddata.github.io/rdflib.js/doc/
Other
562 stars 142 forks source link

Update applyPatch function and add tests for it #574

Closed Jan-PieterBaert closed 1 year ago

Jan-PieterBaert commented 1 year ago

The applyPatch function had a few small bugs when I tried it, so I fixed those and added tests for the function

angelo-v commented 1 year ago

Hi and thanks for your contribution. Can you please describe what bugs you experienced and how your changes fix those?

Jan-PieterBaert commented 1 year ago

The bugs I found:

timbl commented 1 year ago

Looking back at this now it is merged (and broken for solid-ui.) ds was designed to be an Array, not a Collection - which code expects it to be a Collection?

timbl commented 1 year ago

So the test is wrong too. The parameters are expected to be IndexedFormulas, not collections. Let's roll this back. Sorry I don't read it carefully in review.