search

linkedin / Liger-Kernel

Efficient Triton Kernels for LLM Training
BSD 2-Clause "Simplified" License
2.93k stars 147 forks source link

Reference Unsloth in header #216

Closed momochen closed 1 week ago

momochen commented 1 week ago

Summary

Reference Unsloth in header section

Testing Done

momochen commented 1 week ago

@ByronHsu @helloworld1 @yundai424 @qingquansong ptal

helloworld1 commented 1 week ago

In apache license, it says

If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License.

Are those two files considered derived work? If so, we also need to change the NOTICE file.

momochen commented 1 week ago

In apache license, it says

If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License.

Are those two files considered derived work? If so, we also need to change the NOTICE file.

Sure will followup with another ticket to change NOTICE file accordingly.

momochen commented 1 week ago

We are glad to announce that Unsloth and LinkedIn have fully resolved disagreements regarding references!