linkedin / ambry

Distributed object store
https://github.com/linkedin/ambry/wiki
Apache License 2.0
1.75k stars 275 forks source link

Create compaction buffer only based on buffer size #2735

Closed justinlin-linkedin closed 7 months ago

justinlin-linkedin commented 7 months ago

Summary

Only consider the buffer size configuration when creating a buffer in compaction. The buffer size should be orthogonal to the min or max bytes per second in compaction, Let's not use the bytes per second to determine buffer size.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.64%. Comparing base (c56a1fd) to head (e9f8f7a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2735 +/- ## ============================================ - Coverage 70.66% 70.64% -0.02% + Complexity 11565 11556 -9 ============================================ Files 833 833 Lines 70912 70911 -1 Branches 8527 8526 -1 ============================================ - Hits 50111 50097 -14 - Misses 18178 18183 +5 - Partials 2623 2631 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.