search

linkedin / ambry

Distributed object store
https://github.com/linkedin/ambry/wiki
Apache License 2.0
1.75k stars 275 forks source link

MessageFormatException should be treated as Log format error #2744

Closed justinlin-linkedin closed 7 months ago

justinlin-linkedin commented 7 months ago

Summary

When recovering records from log to index, we would just skip malformed records. But this should be treated as Log format error so we can remove this replica's directory and start over.

Test

Unit test

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.66%. Comparing base (4a4ee68) to head (752079c).

Files Patch % Lines
.../github/ambry/messageformat/BlobStoreRecovery.java 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2744 +/- ## ========================================= Coverage 70.65% 70.66% - Complexity 11584 11593 +9 ========================================= Files 833 833 Lines 71007 71009 +2 Branches 8532 8532 ========================================= + Hits 50171 50177 +6 + Misses 18208 18206 -2 + Partials 2628 2626 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.