search

linkedin / ambry

Distributed object store
https://github.com/linkedin/ambry/wiki
Apache License 2.0
1.75k stars 275 forks source link

Add filename to replication exception message #2745

Closed litingulfs closed 7 months ago

litingulfs commented 7 months ago

We currently have at least one ambry-server host that fails to start up with the exception message below. Make it easier to debug by adding the name of the replication token file that is being read.

2024/03/25 15:04:01.391 ERROR [AmbryServer] [main] [ambry-server] [] Error during startup
com.github.ambry.replication.ReplicationException: IO error deserializing replica tokens
    at com.github.ambry.replication.ReplicaTokenPersistor$ReplicaTokenSerde.deserializeTokens(ReplicaTokenPersistor.java:233) ~[com.github.ambry.ambry-replication-0.4.327.jar:?]
    at com.github.ambry.replication.DiskTokenPersistor.retrieve(DiskTokenPersistor.java:95) ~[com.github.ambry.ambry-replication-0.4.327.jar:?]
    at com.github.ambry.replication.ReplicationEngine.retrieveReplicaTokensAndPersistIfNecessary(ReplicationEngine.java:433) ~[com.github.ambry.ambry-replication-0.4.327.jar:?]
    at com.github.ambry.replication.ReplicationManager.start(ReplicationManager.java:149) ~[com.github.ambry.ambry-replication-0.4.327.jar:?]
codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 52.76%. Comparing base (4a4ee68) to head (ea09305).

Files Patch % Lines
...ithub/ambry/replication/ReplicaTokenPersistor.java 0.00% 2 Missing :warning:
...va/com/github/ambry/cloud/CloudTokenPersistor.java 0.00% 1 Missing :warning:
...a/com/github/ambry/store/DumpReplicaTokenTool.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2745 +/- ## ============================================= - Coverage 70.65% 52.76% -17.90% + Complexity 11584 7942 -3642 ============================================= Files 833 833 Lines 71007 71007 Branches 8532 8532 ============================================= - Hits 50171 37465 -12706 - Misses 18208 30534 +12326 - Partials 2628 3008 +380 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.