search

linkedin / ambry

Distributed object store
https://github.com/linkedin/ambry/wiki
Apache License 2.0
1.75k stars 275 forks source link

Print out mount path when replica token file fail to deserialize #2746

Closed justinlin-linkedin closed 5 months ago

justinlin-linkedin commented 7 months ago

Summary

When replication manager starts, it will read the remote replica tokens from a file, and then try to deserialize it. When it fails on deserialization, the ambry-server would fail to start. However, we are not able to see from the log or stack trace which replica file is not able to deserialize. This PR would make sure we print that information out.

Test

Unit test

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.65%. Comparing base (4a4ee68) to head (96dd63d).

Files Patch % Lines
...ithub/ambry/replication/ReplicaTokenPersistor.java 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2746 +/- ## ============================================ - Coverage 70.65% 70.65% -0.01% - Complexity 11584 11586 +2 ============================================ Files 833 833 Lines 71007 71009 +2 Branches 8532 8532 ============================================ - Hits 50171 50170 -1 - Misses 18208 18213 +5 + Partials 2628 2626 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.