search

linkedin / ambry

Distributed object store
https://github.com/linkedin/ambry/wiki
Apache License 2.0
1.74k stars 275 forks source link

Fix a bug when adding new partitions in FULL AUTO #2800

Closed justinlin-linkedin closed 2 months ago

justinlin-linkedin commented 2 months ago

Summary

When adding a new partition to a new host in FULL AUTO, we would wait go through helix state transition to create a bootstrap replica before we update the property store to add replicas to data node config. When creating bootstrap replica, we would put the partition name to partitionNameToAmbryParitition map, so later when the property store is updated, we would ignore adding partition to partitionMap. That's why we encountered a Partition Id from stream is unknown error.

This pr fixes that.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.07%. Comparing base (52ba813) to head (9c15c92). Report is 26 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2800 +/- ## ============================================ + Coverage 64.24% 70.07% +5.82% - Complexity 10398 11693 +1295 ============================================ Files 840 841 +1 Lines 71755 72155 +400 Branches 8611 8684 +73 ============================================ + Hits 46099 50561 +4462 + Misses 23004 18961 -4043 + Partials 2652 2633 -19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.