Closed Arun-LinkedIn closed 2 months ago
Attention: Patch coverage is 33.33333%
with 46 lines
in your changes missing coverage. Please review.
Project coverage is 70.00%. Comparing base (
52ba813
) to head (fa5f272
). Report is 26 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
...b/ambry/clustermap/HelixClusterManagerMetrics.java | 33.82% | 45 Missing :warning: |
...m/github/ambry/clustermap/HelixClusterManager.java | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I am not sure about the speed of iterating through 35K partitions every minute to check out its state, can we put some trace log in the Gauge method to print out how long it takes to do that. And if this take a long time, they are some ways we can improve the metric collection.
lastUpdatedTimestamp
in the HelixClusterManagerMetric
so we only have to recalculate every 10 minutes.HelixClusterManager
in the ExternalViewCallback
. We will only calculate whenever there is an update in ExternalView
.
We are adding two types of metrics. One includes 'bootstrap/inactive' replicas as 'down' replicas while other doesn't.