linkedin / ambry

Distributed object store
https://github.com/linkedin/ambry/wiki
Apache License 2.0
1.75k stars 276 forks source link

Record more exceptions for replication #2823

Closed justinlin-linkedin closed 4 months ago

justinlin-linkedin commented 4 months ago

Summary

In ReplicaThread, we try to record exceptions in the metric for error cases. However, we don't have an umbrella exception counter for overall error cases. This PR adds that.

Test

Unit test

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.22%. Comparing base (52ba813) to head (e775ebb). Report is 41 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2823 +/- ## ============================================ + Coverage 64.24% 70.22% +5.98% - Complexity 10398 11758 +1360 ============================================ Files 840 842 +2 Lines 71755 72362 +607 Branches 8611 8708 +97 ============================================ + Hits 46099 50817 +4718 + Misses 23004 18889 -4115 - Partials 2652 2656 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.