search

linkedin / ambry

Distributed object store
https://github.com/linkedin/ambry/wiki
Apache License 2.0
1.75k stars 276 forks source link

Add crc checks in put operation #2915

Closed Arun-LinkedIn closed 1 month ago

Arun-LinkedIn commented 1 month ago

This change makes sure that content of a chunk in a PUT operation is not modified in frontend (due to illegal reference counts of byte buf, etc) while we are writing it to server

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 72.22222% with 15 lines in your changes missing coverage. Please review.

Project coverage is 70.34%. Comparing base (52ba813) to head (717bd4c). Report is 124 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/com/github/ambry/router/PutOperation.java 72.34% 10 Missing and 3 partials :warning:
.../github/ambry/router/NonBlockingRouterMetrics.java 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2915 +/- ## ============================================ + Coverage 64.24% 70.34% +6.10% - Complexity 10398 11980 +1582 ============================================ Files 840 864 +24 Lines 71755 73672 +1917 Branches 8611 8866 +255 ============================================ + Hits 46099 51828 +5729 + Misses 23004 19146 -3858 - Partials 2652 2698 +46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.