What changes are proposed in this pull request, and why are they necessary?
We're changing the null collation of TrinoSqlDialect to from NullCollation.LAST to NullCollation.HIGH since CoralRelToSqlNodeConverter use NullCollation.HIGH. This is an incremental piece that works towards the goal of eventually getting rid of TrinoSqlDialect and using CoralRelToSqlNodeConverter as the common coral dialect.
How was this patch tested?
New unit test:
testAliasOrderByASC
Testing that the translated Trino sql explicitly says NULLS FIRST since we're translating from Hive and that is the default null ordering for ASC in Hive
What changes are proposed in this pull request, and why are they necessary?
We're changing the null collation of
TrinoSqlDialectto from NullCollation.LAST to NullCollation.HIGH sinceCoralRelToSqlNodeConverteruse NullCollation.HIGH. This is an incremental piece that works towards the goal of eventually getting rid ofTrinoSqlDialectand usingCoralRelToSqlNodeConverteras the common coral dialect.How was this patch tested?
New unit test:
testAliasOrderByASCTesting that the translated Trino sql explicitly says NULLS FIRST since we're translating from Hive and that is the default null ordering for ASC in Hive./gradlew clean build
waiting on i-tests