What changes are proposed in this pull request, and why are they necessary?
Issue: For select * statements, passing a SqlNode (that was converted from a incremental RelNode using CoralRelToSqlNodeConverter) into the coral graph visualizer results in a graph without a select_list edge. For example:
Cause: During the conversion of a CoralRelNode to its CoralSqlNode representation, select *nodes are "wrapped"
in a SELECT statement that has no clauses, leading to a select *SqlNode with null selectList even though there is an implicit * clause. Which in turn, the implicit * is not picked up by the coral visualizer.
How was this patch tested?
Test select * queries in SqlNodeVisualizationUtilTest and make sure the graphs generated have a select_list edge where list_item is *.
What changes are proposed in this pull request, and why are they necessary?
Issue: For
select *
statements, passing a SqlNode (that was converted from a incremental RelNode usingCoralRelToSqlNodeConverter
) into the coral graph visualizer results in a graph without a select_list edge. For example: Cause: During the conversion of a CoralRelNode to its CoralSqlNode representation,select *
nodes are "wrapped" in a SELECT statement that has no clauses, leading to aselect *
SqlNode
with nullselectList
even though there is an implicit*
clause. Which in turn, the implicit * is not picked up by the coral visualizer.How was this patch tested?
Test
select *
queries inSqlNodeVisualizationUtilTest
and make sure the graphs generated have a select_list edge where list_item is *.