search

linkedin / cruise-control

Cruise-control is the first of its kind to fully automate the dynamic workload rebalance and self-healing of a Kafka cluster. It provides great value to Kafka users by simplifying the operation of Kafka clusters.
https://github.com/linkedin/cruise-control/tags
BSD 2-Clause "Simplified" License
2.74k stars 587 forks source link

Incorrect variable? (in PercentileMetricAnomalyFinderConfig) #1438

Closed runom closed 3 years ago

runom commented 3 years ago

Hi, I have a question.

I want to use metric anomaly detection, so I'm reading the relevant code.

https://github.com/linkedin/cruise-control/blob/1bff713ebbfb449b0f7a0425663d6b7c93576a13/cruise-control-core/src/main/java/com/linkedin/cruisecontrol/detector/metricanomaly/PercentileMetricAnomalyFinderConfig.java#L65-L70

At line 70, is METRIC_ANOMALY_PERCENTILE_LOWER_THRESHOLD_DOC correct? I think it should be used METRIC_ANOMALY_LOWER_MARGIN_DOC instead.

efeg commented 3 years ago

@runom Thanks for reporting this issue! This is absolutely a bug -- I will create a PR to fix it. -- Please let us know if you would encounter other issues or have questions.

runom commented 3 years ago

I've confirmed it. Thanks!