search

linkedin / cruise-control

Cruise-control is the first of its kind to fully automate the dynamic workload rebalance and self-healing of a Kafka cluster. It provides great value to Kafka users by simplifying the operation of Kafka clusters.
https://github.com/linkedin/cruise-control/tags
BSD 2-Clause "Simplified" License
2.74k stars 585 forks source link

`Remove-disks` endpoint doesn't work when used with `skip_hard_goal_check` and `verbose` parameter #2105

Closed ShubhamRwt closed 8 months ago

ShubhamRwt commented 8 months ago

When we try to use the remove-disks endpoint and try to use a curl command with skip_hard_goal_check or verbose parameter

curl -vv -X POST "http://localhost:9090/kafkacruisecontrol/remove_disks?json=true&dryrun=true&verbose=false&skip_hard_goal_check=false&brokerid_and_logdirs=0-%2Fvar%2Flib%2Fkafka%2Fdata-0%2Fkafka-log0"

the endpoint doesn't work and return this error 

{"version":1,"errorMessage":"Unrecognized endpoint parameters in REMOVE_DISKS POST request: [skip_hard_goal_check, verbose].","stackTrace":""}
mhratson commented 8 months ago

What's the behaviour you're expecting?

The error shows those are unsupported parameters

ShubhamRwt commented 8 months ago

@mhratson Hi, I was expecting that if it doesn't support those parameter then instead of giving error shouldn't it just ignore it? Also shouldn't it be fine to support parameters like verbose?

mhratson commented 8 months ago

giving error shouldn't it just ignore it?

Evidently it's not the current behavior.

Also shouldn't it be fine to support parameters like verbose?

PRs are welcomed :)

ShubhamRwt commented 8 months ago

Thanks, I will create one