search

linkedin / cruise-control

Cruise-control is the first of its kind to fully automate the dynamic workload rebalance and self-healing of a Kafka cluster. It provides great value to Kafka users by simplifying the operation of Kafka clusters.
https://github.com/linkedin/cruise-control/tags
BSD 2-Clause "Simplified" License
2.68k stars 574 forks source link

Document units in capacityJBOD.json #2121

Closed marcelloromani closed 4 months ago

marcelloromani commented 4 months ago

It's not clear what the units are for the provided example capacity JSON file: https://github.com/linkedin/cruise-control/blob/migrate_to_kafka_2_5/config/capacityJBOD.json

marcelloromani commented 4 months ago

They appear to be documented in code comments:

https://github.com/linkedin/cruise-control/blob/migrate_to_kafka_2_4/cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/config/BrokerCapacityInfo.java#L17

and

https://github.com/linkedin/cruise-control/blob/migrate_to_kafka_2_5/cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/config/BrokerCapacityConfigFileResolver.java#L143

mhratson commented 4 months ago

They appear to be documented in code comments:

👍 Closing.