search

linkedin / cruise-control

Cruise-control is the first of its kind to fully automate the dynamic workload rebalance and self-healing of a Kafka cluster. It provides great value to Kafka users by simplifying the operation of Kafka clusters.
https://github.com/linkedin/cruise-control/tags
BSD 2-Clause "Simplified" License
2.68k stars 574 forks source link

update scala to support java 21 #2139

Closed slaupster closed 5 hours ago

slaupster commented 3 months ago

A number of java interop issues have been resolved in scala:

https://github.com/scala/scala/pulls?q=label%3A%22java+interop%22+is%3Aclosed

As it stands compiling using jdk 21 fails with:

116.0 > Task :cruise-control:compileScala
116.0 error:
116.0   bad constant pool index: 0 at pos: 48461
116.0      while compiling: <no file>
116.0         during phase: globalPhase=<no phase>, enteringPhase=<some phase>
116.0      library version: version 2.13.10
116.0     compiler version: version 2.13.10

Its not clear which of the versions between .10 and .13 resolves it but I think its safe to move to .13 which also happens to resolve the compile issue.

This PR resolves #2138.

CCisGG commented 6 hours ago

Running internal check and will merge once the check passes.