Fix: intra.broker.goals cannot be configured as default.goals

[k0b3rIT]

Summary

1. Why: KafkaCruiseControlConfig sanity checks prevent to configure inter broker goals as default goals.
2. What: Modify the sanity check to allow adding intra broker goals to the default.goals

Expected Behavior

I can add (enable) goals to the default.goals list from both the intra and inter broker goals

Actual Behavior

Sanity checks ensure the following rules:

• goals and intra broker goals should be disjoint (an intra broker goal cant be in the goals and the intra.broker.goals at the same time)
• default.goals should be a subset of goals (As a result of this, we could not add intra broker goal to the default.goals)
• intra.broker.goals cant be empty (you could not move all the intra broker roles to the goals)

We could not add intra goal to the default.goals without a trick (see in the workaround section)

Steps to Reproduce

Try to enable an intra broker goal by adding it to the default. goals

Known Workarounds

You can remove 1 intra broker goal from the intra.broker.goals config and add that to the goals (keep in mind that the other one should be in the intra.broker.goals as the list cant be empty) this way you can add that 1 goal to the default.goals and enable it

Note that this way we still cant enable both of the currently available intra broker goals as 1 have to be in the intra.broker.goals list to avoid hitting the mentioned sanity check. So only 1 intra goal at a time.

Categorization

• [ ] documentation
• [x] bugfix
• [ ] new feature
• [ ] refactor
• [ ] security/CVE
• [ ] other

[viktorsomogyi]

@CCisGG would you review this please if you have some time?