search

linkedin / css-blocks

High performance, maintainable stylesheets.
http://css-blocks.com/
BSD 2-Clause "Simplified" License
6.34k stars 152 forks source link

Support to ember-engines #256

Open villander opened 5 years ago

villander commented 5 years ago

Hi @chriseppstein I'm working o roadmap to ember-engines 1.0. I just don't understand how this does not work with ember-engines, and Linkedin uses ember-engines on its main site. Maybe it's a workaround, I don't know

But I would help on anything to make this able of running with ember engines.

thanks!

GCheung55 commented 4 years ago

@villander I just tried css-blocks with ember-engines.

The way it works is that the CSS is included in the app.css file instead of the engine's. So in that sense, this isn't working as expected.

chriseppstein commented 4 years ago

@GCheung55 The optimization step requires all of the styles be optimized together. Once that is done, the styles can then be split back into their respective engines. Code splitting is a feature we plan to add later. The feeling right now is that a global optimization may pay enough dividends that code splitting isn't a very big win. As with most things performance related, the answer is probably "it depends". Either way, we plan to implement the code-splitting feature in the future.