search

linkedin / css-blocks

High performance, maintainable stylesheets.
http://css-blocks.com/
BSD 2-Clause "Simplified" License
6.34k stars 152 forks source link

language-server test and lint configuration #339

Closed jackson-dean closed 4 years ago

jackson-dean commented 4 years ago

there error is due to missing a test file. i'll update this with a simple test.

jackson-dean commented 4 years ago

I am still working on tests, but I think I have things in a more readable/manageable state. up to you, but my personal feeling is this is fine to merge if you want to play around with it.

jackson-dean commented 4 years ago

Ok, I dug around through the vscode language serve code to see how they are testing it. It is actually a pretty nice way and was able to get some high level acceptance style tests. I think it should be good as a sanity check. But definitely will need to follow up with more unit tests and maybe a couple more sanity check acceptance tests. I think what is here gives some confidence that things more or less work together properly. There's still some dirty stuff in there, but I don't want to be precious about it. I think its in a state where it can be quickly refactored now that it's more separated out rather than keep mucking around with this PR. I can add a few more tests if you want though!

jackson-dean commented 4 years ago

@chriseppstein let me know what you think when you get a chance to take a look.