linkedin / css-blocks

High performance, maintainable stylesheets.
http://css-blocks.com/
BSD 2-Clause "Simplified" License
6.33k stars 152 forks source link

Definition File Full Workflow - Acceptance Tests #455

Closed timlindvall closed 4 years ago

timlindvall commented 4 years ago

This PR includes two commits...

fix: Allow quotes surrounding block-name.

Definition file output wraps the block-name in quotes, but there are existing rules in CSS Blocks disallowing this. This removes this rule, using stripQuotes() to unwrap the block-name value. With this change, block-name, block-id, and block-class will all behave in the same way.

test: Definition Files Basic Acceptance Tests.


This PR only encompasses basic acceptance coverage using a source CSS Blocks file without any imports, exports, or aliases.

CI is going to fail because of missing types for ember-cli-htmlbars. Manually verified that yarn test in the /core directory is passing locally.

timlindvall commented 4 years ago

^ rebased off of latest ember-rewrite