linkedin / css-blocks

High performance, maintainable stylesheets.
http://css-blocks.com/
BSD 2-Clause "Simplified" License
6.33k stars 152 forks source link

Conflict Resolver API Changes #6

Open chriseppstein opened 7 years ago

chriseppstein commented 7 years ago

The current resolver resolves all selectors that match the target block object in the key selector. This means that states targeting that same object get overridden too. That seemed like a good idea, but it turns out to be sub-optimal for many use cases, especially inheritance (which is a resolution abstraction)

A new syntax for resolution is documented in the readme and needs to be implemented.

https://github.com/css-blocks/css-blocks/blob/master/README.md#resolving-state-conflicts

amiller-gh commented 6 years ago

Updated link: https://github.com/css-blocks/css-blocks/blob/master/OLD_README.md#resolving-state-conflicts

@chriseppstein, whats the status of this? If theres still work to do, do you want us do hit this before public release?

chriseppstein commented 6 years ago

This work hasn’t happened yet. I’d like to revisit the design. It’s not going to happen before we open source it. All of our public docs should be limited to our currently supported resolution syntax.