linkedin / detext

DeText: A Deep Neural Text Understanding Framework for Ranking and Classification Tasks
BSD 2-Clause "Simplified" License
1.26k stars 134 forks source link

allowed unknown args to main() #29

Closed zhoutong-fu closed 4 years ago

zhoutong-fu commented 4 years ago

Description

This is a follow-up to #25 to allow additional unknown arguments.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

List all changes

Testing

pytest sh run_detext.sh sh run_detext_multitask.sh

Test Configuration:

Checklist

zhoutong-fu commented 4 years ago

can we keep the run_detext.sh script (maybe move to test resources) for the toy example run described in the readme?

Done

StarWang commented 4 years ago

LGTM. Thanks

xwli-chelsea commented 4 years ago

can we keep the run_detext.sh script (maybe move to test resources) for the toy example run described in the readme?

Done

Thanks! LGTM