Allow for AccessFlags.ACC_SYNTHETIC.

linkedin / dexmaker

A utility for doing compile or runtime code generation targeting Android's Dalvik VM

Apache License 2.0

1.88k stars 249 forks source link

Allow for AccessFlags.ACC_SYNTHETIC. #117

Closed tdrhq closed 6 years ago

tdrhq commented 6 years ago

AFAICT, there should be no reason this shouldn't be supported. It's just adding an extra flag to the Method. Given that DexMaker is used to generate code, it makes sense that we're going to frequently generate synthetic methods.

I didn't really test this, except for validating that the constants in Modifier, matches the constants in AccessFlags.

tdrhq commented 6 years ago

Ping!

drewhannay commented 6 years ago

Sorry for the delay, we've been changing how we schedule and triage open source work within our normal schedules and this one slipped through the cracks. Looks good to me, thanks for the contribution :)