When using ProxyBuilder#withSharedClassLoader(), the proxy classes for the same class will be the same even though different interfaces are specified by implementing()

[tmurakami]

• dexmaker 2.19.1

public class ProxyBuilderTest {

    @Test
    public void test() throws IOException {
        Class<?> c1 = ProxyBuilder.forClass(C.class)
                                  .implementing(I1.class)
                                  .withSharedClassLoader()
                                  .buildProxyClass();
        Class<?> c2 = ProxyBuilder.forClass(C.class)
                                  .implementing(I2.class)
                                  .withSharedClassLoader()
                                  .buildProxyClass();
        assertNotSame(c1, c2); // java.lang.AssertionError: expected not same
    }

    static class C {
    }

    interface I1 {
    }

    interface I2 {
    }

}

[moltmann]

yes. We need to consider the interfaces when we generate the file name for the class in Dexmaker#generateFileName

Do you want to add the test and fix?

[tmurakami]

I guess the cause of this issue is that ProxyBuilder#getMethodNameForProxyOf() returns the same value. I wonder if we need to modify DexMaker#generateFileName().

Anyway, I will try sending a PR.