linkedin / dexmaker

A utility for doing compile or runtime code generation targeting Android's Dalvik VM
Apache License 2.0
1.86k stars 248 forks source link

Does not introduce transitive dependency of mockito per README #166

Closed chao2zhang closed 4 years ago

chao2zhang commented 4 years ago

In the README.md, there is the following: Note: The dependency on Mockito will be transitively included, so there's no need to specify both Mockito AND dexmaker-mockito

However, in dexmaker-mockito/build.gradle, mockito dependency is implementation, not API. Therefore adding androidTestImplementation 'com.linkedin.dexmaker:dexmaker-mockito:2.25.1' does not introduce the mockito dependency transitively

drewhannay commented 4 years ago

This is probably left over from before api and implementation were a thing in Gradle.

Do you think we should change the documentation or should we change the dependency to api? I probably prefer the latter.

chao2zhang commented 4 years ago

Latter is also preferred from me because clients need to keep the dexmaker version in sync with mockito's, which is difficult for dexmaker 2.28.0 because it really depends on mocktio 2.28.2