search

linkedin / dustjs

Asynchronous Javascript templating for the browser and server
http://dustjs.com
MIT License
2.91k stars 478 forks source link

Performance issue with 2.7.4 #751

Open mrcrgl opened 8 years ago

mrcrgl commented 8 years ago

Hi,

I've found an performance issue in the current 2.7 branch and would fix that. I also found out that the code in master is already restructured and may not be affected anymore. Will the current master be merged in 2.7 or is it worth it to fix that 2.7 branch?

(v8 does not optimise that function) https://github.com/linkedin/dustjs/blob/2.7/lib/parser.js#L268

Marc

sethkinast commented 8 years ago

The parser code is automatically generated by peg.js. Master does use a newer version of peg, but if the code it generates could be optimized you'll probably want to open an issue upstream with peg.

mrcrgl commented 8 years ago

Thank you for help. I didn't tried the newer version yet. Is the release of the master already scheduled?