#63. Dynamometer does not support negative block id's

linkedin / dynamometer

A tool for scale and performance testing of HDFS with a specific focus on the NameNode.

BSD 2-Clause "Simplified" License

131 stars 34 forks source link

#63. Dynamometer does not support negative block id's #66

Open jojochuang opened 5 years ago

jojochuang commented 5 years ago

Fixes #63 Submitted the PR on behalf of @fangyurao. The PR was adopted from this commit: https://github.com/fangyurao/dynamometer/commit/0f077a6e8094b2154142f09bd034490fbfebfa85

xkrogen commented 5 years ago

Great find, thanks @jojochuang ! And sorry for the delay in my response.

I think the current logic is a little more verbose than necessary, can we just use Math#floorMod()?

xkrogen commented 5 years ago

Hey @jojochuang , I put up a patch using Math.floorMod() to make the logic cleaner in PR #83. Can you take a look and see if you think it looks good?

Also cc @fengnanli