linkedin / eyeglass

NPM Modules for Sass
741 stars 60 forks source link

Package.json: restore file dependencies to link dependencies #220

Closed stefanpenner closed 5 years ago

stefanpenner commented 5 years ago

restore file dependencies to link, as file in yarn only copies assets rather than symlink which makes me constantly troll myself in development.

@chriseppstein I do understand link is non-standard, and maybe it's not worth changing back. Would love to hear your thoughts.

rwjblue commented 5 years ago

Link is definitely valid for yarn, it’s just non-standard for npm. AFAICT, this repo is using yarn for all it’s local development so I would think link is totally fine there.

Am I missing something?

chriseppstein commented 5 years ago

I like the semantics of link: over file: and I'm happy to merge it in, but this change breaks the build and I'm not sure what about my ember config is wrong that's causing this to fail.

rwjblue commented 5 years ago

The error (during ember test) is:

Error while loading rule '@typescript-eslint/restrict-plus-operands': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser.

Most likely need to follow what it says here:

If you want to use rules which require type information, you will need to specify a path to your tsconfig.json file in the "project" property of "parserOptions".

{
  "parser": "@typescript-eslint/parser",
  "parserOptions": {
    "project": "./tsconfig.json"
  },
  "plugins": ["@typescript-eslint"],
  "rules": {
    "@typescript-eslint/restrict-plus-operands": "error"
  }
}
chriseppstein commented 5 years ago

@rwjblue I tried adding parser options before I commented. it didn't fix the error. 🤷‍♂️

Note: The parser options were are already set through eslint configuration inheritance, so what I tried was adding them locally to this project's config. it didn't make any difference.