Open ryosagisu opened 5 years ago
in the middle of playing with this on branch https://github.com/linkedin/goavro/tree/145
While the above branch passes all the included tests, there are some overlap and redundancy between some of the data types, and I'd like to refactor a bit more before I merge it back in.
I'd be happy to have some feedback if you're interested in providing it.
Sure, I've seen your code and it's much cleaner than what I've done. I'll try to play it later, when I got some times. Thanks
hello, any help needed to merge branch https://github.com/linkedin/goavro/tree/145?
In my system I need to get
Schema
from Avro message, and I notice we could getSchema
by calling(*OCFReader).Metadata()
. But when generating newOCFReader
it has to generate newcodec
, and I see this is quite expensive to do. Ref: https://github.com/linkedin/goavro/blob/master/ocf.go#L114-L171So, I propose to create function that will return Avro metadata when called, without creating new
OCFReader
. This is what I used now:What do you guys think?