linkedin / greykite

A flexible, intuitive and fast forecasting library
BSD 2-Clause "Simplified" License
1.81k stars 106 forks source link

Importing Forecaster gives error for United States class (Holiday?) #108

Closed sarkistashjian closed 1 year ago

sarkistashjian commented 1 year ago

Hello, I have been running greykite for months and I got a new error which has never been an issue before when I import Forecaster. Here is a screenshot of the details. Is there a fix here I am unaware of? I am running greykite 0.5.0 greykite_error

bhatt-priyadutt commented 1 year ago

@sarkistashjian I am getting the same error and it is because of the holidays package, please try using holidays version before 15th may. you have to specify the version for holidays package explicitly. image

sayanpatra commented 1 year ago

Thanks for the diagnosis @bhatt-priyadutt. @sarkistashjian Does pinning down the holidays version resolve the issue? You can pin the version here: https://github.com/linkedin/greykite/blob/8c87e36db9c812cf6baf2da61b5bb940fe30c3d4/setup.py#L15

sarkistashjian commented 1 year ago

yes, I believe this fixed it! I used !pip install holidays==0.24 @sayanpatra

Thank you, @bhatt-priyadutt

sayanpatra commented 1 year ago

Thanks, closing the ticket.