search

linkedin / isolation-forest

A Spark/Scala implementation of the isolation forest unsupervised outlier detection algorithm with support for exporting in ONNX format.
Other
223 stars 47 forks source link

Publish for Scala 2.12 #14

Closed nightscape closed 4 years ago

nightscape commented 4 years ago

Hi all!

Would it be possible to cross-publish this project to Scala 2.12? I'm trying to upgrade Microsoft's MMLSpark to Scala 2.12, but I'm currently blocked by isolation-forest having only a 2.11 build. There seem to be a few options to do this, e.g. https://github.com/prokod/gradle-crossbuild-scala or https://github.com/ADTRAN/gradle-scala-multiversion-plugin

Thanks a lot!

jverbus commented 4 years ago

@nightscape, thanks for reaching out!

The automated release library I'm using doesn't current support building and publishing multiple artifacts using different dependencies under the same release version. I filed a request for this a while ago and they are working on it.

https://github.com/mockito/shipkit/issues/858

I can manually build an artifact using 2.12 for the most recent isolation forest version and publish it to JCenter and Maven Central. This week is pretty packed for me, but I will aim to do this the following week.

nightscape commented 4 years ago

In case your interested I could create an SBT build as well, but you're probably more familiar with Gradle and have therefore decided to use it here.

jverbus commented 4 years ago

Thanks for the offer, but we use Gradle internally at LinkedIn and would like to stick with it here.

jverbus commented 4 years ago

Hey @nightscape, a new artifact built with Scala 2.12 is now available in Maven Central.

https://oss.sonatype.org/#nexus-search;quick~isolation-forest 

<dependency>
  <groupId>com.linkedin.isolation-forest</groupId>
  <artifactId>isolation-forest_2.4.3_2.12</artifactId>
  <version>0.3.3</version>
</dependency>
jverbus commented 4 years ago

@nightscape: Please let me know if this works for you. Thanks!

nightscape commented 4 years ago

Hey @jverbus, thanks a lot! It seems that the artifact is currently only in the LinkedIn Nexus repo at https://oss.sonatype.org/service/local/repositories/comlinkedin-1736/content/ Does it maybe have to be released and promoted?

jverbus commented 4 years ago

@nightscape: Yep, it needed to be released. It should now be available. Thanks!

nightscape commented 4 years ago

I successfully pulled 1.0.0 for Scala 2.12. Thanks a lot!