linkedin / li-apache-kafka-clients

li-apache-kafka-clients is a wrapper library for the Apache Kafka vanilla clients. It provides additional features such as large message support and auditing to the Java producer and consumer in the open source Apache Kafka.
BSD 2-Clause "Simplified" License
133 stars 52 forks source link

Add release on tag for circleci #60

Closed radai-rosenblatt closed 7 years ago

radai-rosenblatt commented 7 years ago

docs - https://circleci.com/docs/2.0/workflows/#git-tag-job-execution

smccauliff commented 7 years ago

LGTM. The only thing that you might want to add is some check that the version gradle knows about is also the version used in the tag. Since this in the gradle.properties file it should be straight forward to extract this from gradle.properties.

radai-rosenblatt commented 7 years ago

now with 60% more regexp