search

linkedin / linkedin-gradle-plugin-for-apache-hadoop

Apache License 2.0
117 stars 76 forks source link

Added possibility to have Azkaban password in configuration JSON. #130

Closed vanaoff closed 7 years ago

vanaoff commented 7 years ago

There are several cases when it is beneficial to have password stored directly in configuration JSON, so the plugin doesn't need to open system console. Among these situations are for example building via IDE plugin or Jenkins build. In both examples is no system console available.

convexquad commented 7 years ago

Thanks for contributing this Pull Request! I am about to take off on vacation for the holidays, so give me a little while to finish reviewing it.

vanaoff commented 7 years ago

Thank you for review. How often you usually accept pull requests?

convexquad commented 7 years ago

+1. Thank you @vanaoff for this contribution. We accept pull requests regularly. Each year LinkedIn shuts down for one week after Christmas, and then I took some extra time off, so I am just getting back from the holidays. Normally we will review/commit any pull requests more quickly.

convexquad commented 7 years ago

Ah, we have a new requirement for two-factor authentication for LinkedIn GitHub repos - let me see how I can re-establish my commit access and then I will commit your PR.

vanaoff commented 7 years ago

Thanks @convexquad and @pranayhasan!

convexquad commented 7 years ago

I got my write access restored. Committing this PR.

I'll push a new build to plugins.gradle.org in a day or two.

convexquad commented 7 years ago

@vanaoff Just FYI I published a new build to plugins.gradle.org in case you are using that

vanaoff commented 7 years ago

Thanks, that's great!